-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: disable scripts #2550
rust: disable scripts #2550
Conversation
Riolku
commented
Dec 5, 2023
•
edited
Loading
edited
d222de3
to
f3d464c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2550 +/- ##
=======================================
Coverage 92.85% 92.86%
=======================================
Files 1025 1025
Lines 38324 38324
=======================================
+ Hits 35586 35589 +3
+ Misses 2738 2735 -3 ☔ View full report in Codecov by Sentry. |
f3d464c
to
9adba6c
Compare
CMakeLists.txt
Outdated
option(BUILD_BENCHMARK "Build benchmarks." FALSE) | ||
option(BUILD_EXAMPLES "Build examples." FALSE) | ||
option(BUILD_JAVA "Build Java API." FALSE) | ||
option(BUILD_NODEJS "Build NodeJS API." FALSE) | ||
option(BUILD_PYTHON "Build Python API." FALSE) | ||
option(BUILD_SHELL "Build Interactive Shell" TRUE) | ||
option(BUILD_SINGLE_FILE_HEADER "Build single file header." TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that this requires python in the description?
And while it's not entirely related, the Building from Source docs still say that python headers are needed, while that should only be necessary if building the python API and could be moved to an API-specific dependency.
Strictly speaking this change will also mean that python itself is entirely optional, but maybe it's easier to still say that python is required, since usually people will want the single file header, than it would be to explain the conditions where it is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: python dev headers, the docs just need to be redeployed (kuzudb/kuzu-docs#48 was merged).
Rust doesn't need the single file header. In the interest of keeping the crate size small, I've simply added a flag that disables generation of the single file header. The single file header still builds by default. Additionally, Rust shouldn't use the automatic grammar generation. I've also disabled that in the crate build.
9adba6c
to
f1dd6b6
Compare